Simplifying cudaq::state support. #3622
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
schweitzpgi
force-pushed
the
ch-reduced.state
branch
from
79a7f6c to
6a19d57
Compare
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
schweitzpgi
force-pushed
the
ch-reduced.state
branch
from
e7e649e to
1345427
Compare
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
1tnguyen
force-pushed
the
ch-reduced.state
branch
from
a0143e6 to
6f42aa6
Compare
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
1tnguyen
force-pushed
the
ch-reduced.state
branch
from
6f42aa6 to
13f22f0
Compare
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
This PR greatly simplifies the use of cudaq::get_state by limiting its applicability strictly to local simulation execution contexts. Prior attempts were made to make cudaq::get_state generally available regardless of the target execution context. This level of support is being discontinued. - Move the qvector ctor overloads to the cudaq::state class. This simplifies qvector by making it only possible to initialize a qvector with a cudaq::state object and dropping all the overloads. - Fix tests. Adapt the regression tests. - Drop state with non-simulation targets. - Add code to distinguish between floats and complex floats and get rid of a bunch of redundant code that wasn't needed. Also, update tests. - Make all command line arguments be in the same order. - Don't implicit handle density matrix as a flattened vector (#6) Signed-off-by: Eric Schweitz <[email protected]>
Signed-off-by: Thien Nguyen <[email protected]>
Signed-off-by: Eric Schweitz <[email protected]>
schweitzpgi
force-pushed
the
ch-reduced.state
branch
from
3c5a271 to
a2881c9
Compare
sacpis
approved these changes
Nov 20, 2025
Collaborator
sacpis
left a comment
sacpis
left a comment
There was a problem hiding this comment.
LGTM. Thanks @schweitzpgi.
Collaborator
|
Seems like we have a few test failures. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR greatly simplifies the use of cudaq::get_state by limiting its applicability strictly to local simulation execution contexts. Prior attempts were made to make cudaq::get_state generally available regardless of the target execution context. This level of support is being discontinued.
Description